[opentitanlib] further refactors to UartConsole
#28805
Open
+469
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `set_break` needs to be on `ConsoleDevice` because `UartConsole` expects it to be there, so it can turn stdin breaks into console breaks. This feature is now moved to `opentitantool console` (which was the only place this feature was used), so the `set_break` doesn't need to be on `ConsoleDevice` anymore (and also this capability is only available on `Uart` impls anyway). Signed-off-by: Gary Guo <[email protected]>
This can allow multiple concurrent readers to all receive all data. Signed-off-by: Gary Guo <[email protected]>
Signed-off-by: Gary Guo <[email protected]>
Reduce nesting level by 1. Signed-off-by: Gary Guo <[email protected]>
Signed-off-by: Gary Guo <[email protected]>
We always use `stdout` if it's not `None`, so just use a boolean quiet flag instead. Signed-off-by: Gary Guo <[email protected]>
nbdd0121
force-pushed
the
uart-console
branch
from
2180a2d to
c5625b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an utility for UART (consoles)
Broadcasterwhich can be used to disseminate received data to multiple readers and each readers be able to read full history.This can be useful when there're multiple users of UART that need to handle inputs simultaneously. The
opentitantool's logfile option has been refactored to do this so it no longer needs to be part ofUartConsole.